Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature hybrid coord2 #116

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

milicak
Copy link
Collaborator

@milicak milicak commented Sep 21, 2021

CVmix mixing scheme has been added for the hybrid coordinate.

@milicak milicak requested a review from matsbn September 21, 2021 17:08
Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the mod_vcoord.F90 changes are unrelated to CVMix and makes the commit message confusing. I'll approve anyway and maybe revert the mod_vcoord.F90 changes afterwards and commit with appropriate message.

@TomasTorsvik
Copy link
Contributor

Looks good, although the mod_vcoord.F90 changes are unrelated to CVMix and makes the commit message confusing. I'll approve anyway and maybe revert the mod_vcoord.F90 changes afterwards and commit with appropriate message.

@matsbn @milicak
I think it's much easier to make changes before something is merged with the main repository than to fix it later on. This sometimes cause a confusing commit history. Unless it is really urgent, I would suggest to take the time and fix the pull request before merging.

@matsbn matsbn merged commit 3c15130 into NorESMhub:feature-hybrid_coord2 Sep 23, 2021
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants