Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Brunt-Vaisala frequency computation added. #120

Merged

Conversation

milicak
Copy link
Collaborator

@milicak milicak commented Sep 29, 2021

Bottom Brunt-Vaisala frequency computation added. CVMIX CPP is removed. New method to compute interface heights has been implemented.

…d. New method to compute interface heights has been implemented.
@milicak milicak requested a review from matsbn September 29, 2021 11:25
Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just wonder about the purpose of "hcorr" in mod_difest.F. It is set to zero and added to "dh" which seems to be inconsistent with the comment "Take away the accumulated error (could temporarily make dh<0)".

@matsbn matsbn merged commit cb10eeb into NorESMhub:feature-hybrid_coord2 Oct 1, 2021
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Bottom Brunt-Vaisala frequency computation added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants