Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add -DLEVITUS2X option when building with tnx2v1 grid #135

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Do not add -DLEVITUS2X option when building with tnx2v1 grid #135

merged 2 commits into from
Nov 10, 2021

Conversation

JorgSchwinger
Copy link
Contributor

This restores the behavior from before the updated build-scripts. With the tn21-grid, we have always used only 35 vertical z-levels in the output. This saves storage (particularly for HAMOCC) and is good enough for the lower resolution ocean grid, so I think we should stick to it.

@JorgSchwinger JorgSchwinger requested a review from matsbn November 10, 2021 07:15
Copy link
Contributor

@matsbn matsbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no intention to change behaviour in this respect, so great you found this. But please exclude "buildcppc" in the PR. This is compiled python code of "buildcpp" and is system dependent.

@JorgSchwinger
Copy link
Contributor Author

Ok, I have removed the buildcppc file. I will then proceed and merge into master. This should probably also go into the new release branch before making the release tag

@matsbn matsbn self-requested a review November 10, 2021 08:58
@JorgSchwinger JorgSchwinger merged commit aa0a0cf into NorESMhub:master Nov 10, 2021
@JorgSchwinger JorgSchwinger deleted the fix-cppdefs branch November 10, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants