Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct unit of diagnostic field and make conservation and checksum diagnostics selectable by namelist options #205

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Nov 21, 2022

This resolves issues #203 and #204.

Using the NOIIAOC NorESM compset at resolution T62_tn14, the code has been tested on machine betzy.sigma2.no to bit-reproduce current NorESMhub/BLOM/master.

@matsbn matsbn requested a review from TomasTorsvik November 21, 2022 00:42
@TomasTorsvik TomasTorsvik added this to the BLOM/iHAMOCC-1.3.0 milestone Nov 21, 2022
@TomasTorsvik TomasTorsvik added bug Something isn't working enhancement New feature or request labels Nov 21, 2022
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! No complaints from my side.

@TomasTorsvik
Copy link
Contributor

@matsbn I assume you want to merge this yourself? I set you as "assignee" on this PR.

@matsbn matsbn merged commit 8385d62 into NorESMhub:master Nov 21, 2022
@matsbn matsbn deleted the feature-r13fixes branch December 21, 2022 16:38
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Correct unit of diagnostic field and make conservation and checksum diagnostics selectable by namelist options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make budget calculations selectable by namelist option Correct unit of diagnostic variable "dp_trc"
2 participants