Hybrid coordinate enhancements #235
Merged
+2,129
−907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adual change of layer thickness in a transition zone separating interfaces with constant pressure and constant potential density, respectively.
… vertical coordinate.
…emperature restoring flux, surface salinity restoring flux and brine flux.
…or hybrid vertical coordinate and selectable as namelist flag.
| set NIWGF = .4 | ||
| set SMTFRC = .false. | ||
| if ($BLOM_VCOORD == isopyc_bulkml) then | ||
| set CE = .5 |
There was a problem hiding this comment.
Does this mean that CE is undefined if $BLOM_VCOORD /= isopyc_bulkml? Is that ok?
There was a problem hiding this comment.
CE is first set to a common literature value of 0.06 (Fox-Kemper et al., 2008), then adjusted (quite strongly) if $BLOM_VCOORD == isopyc_bulkml. With hybrid coordinate we found reasonable submesoscale eddy-induced overturning strength with the standard value.
JorgSchwinger
approved these changes
Feb 10, 2023
TomasTorsvik
approved these changes
Feb 10, 2023
milicak
approved these changes
Feb 17, 2023
jmaerz
pushed a commit
to jmaerz/BLOM
that referenced
this pull request
Aug 9, 2023
Hybrid coordinate enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hybrid coordinate enhancements that includes: Separate non-local terms for vertical distribution of surface temperature restoring flux, surface salinity restoring flux and brine flux; Gradual change of layer thickness in a transition zone separating interfaces with constant pressure and constant potential density, respectively; Submesoscale eddy-induced transport parameterization for hybrid vertical coordinate.
CI issues on macOS have been fixed.
Model results change when using hybrid coordinate, but are unchanged with isopycnic coordinate.