-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BLOM regression test functionality #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should look more into the regression test functionality, but I don't see any reason to hold back on merging this PR.
@TomasTorsvik - thanks for the review. Do we need to wait for the review for Mats as well. I'd like to get this into a updated NORESM development snapshot that is needed for the Making Waves project. This is the last branch that is still pointing to my own forked code. |
@mvertens - I usually wait for review from Mats when a PR touches physics or model coupling (i.e. not purely BGC). Since this PR is mainly adding test functionality it is different from the PRs that we usually deal with. If you need this functionality in your current work, I suggest we merge it so that it doesn't stop you in your progress. Otherwise I would prefer to wait for input from Mats. |
This PR has changes to buildnml and to the testdefs directory to enable BLOM to have its first set of regression tests.
This PR resolves issue #258.
To see how the regression test is working - do the following:
(Note: the BLOM external points to my repository until this PR is merged)
will give the following output
To run a test suite and also generate baselines:
Baselines for the above aux_blom_noresm tests will be created in
/cluster/shared/noresm/noresm_baselines/<your_baseline_directory_name>
More documentation on regression testing in NorESM can be found at:
https://noresm-docs.readthedocs.io/en/noresm2/testing/systemtests.html