Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to run C-isotopes #286

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fixes to run C-isotopes #286

merged 1 commit into from
Oct 17, 2023

Conversation

JorgSchwinger
Copy link
Contributor

This fixes a model crash when running C-isotopes with the sediment activated. It also removes the error message when C-isotopes are build with sediment activated.

@JorgSchwinger
Copy link
Contributor Author

Note: this doesn't fix the issue of being not bfb with the master before #280

@JorgSchwinger JorgSchwinger requested review from matsbn, mvertens and jmaerz and removed request for matsbn October 17, 2023 18:58
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the one-line fix from Alok, right? - the rest is more the optics, it seems.

@JorgSchwinger
Copy link
Contributor Author

Sorry, I should have left out the code-cosmetics, but there is a real fix in line 684: the definition of one variable was duplicated

@JorgSchwinger JorgSchwinger merged commit 51e7527 into NorESMhub:master Oct 17, 2023
12 checks passed
@JorgSchwinger JorgSchwinger deleted the fix-c_isotopes_rstw branch October 17, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants