Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to run OAE experiments with an OmegaA threshold #291

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add capability to run OAE experiments with an OmegaA threshold #291

merged 1 commit into from
Oct 20, 2023

Conversation

JorgSchwinger
Copy link
Contributor

No description provided.

TomasTorsvik
TomasTorsvik approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Initially I got a bit confused about the point of including this threshold option.

@TomasTorsvik TomasTorsvik added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Oct 20, 2023
@TomasTorsvik TomasTorsvik added this to the preparing for noresm2.1 milestone Oct 20, 2023
@JorgSchwinger
Copy link
Contributor Author

Thank you Tomas, I just wanted to have this in the last CMIP6-bw-compatible release since we are using this in project where we look at CMIP6 scenarios with additional ocean alkalinization.

@JorgSchwinger JorgSchwinger merged commit ad35301 into NorESMhub:master Oct 20, 2023
12 checks passed
@JorgSchwinger JorgSchwinger deleted the feature-limit_OAE branch October 20, 2023 07:16
@jmaerz jmaerz mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTorsvik TomasTorsvik TomasTorsvik approved these changes

Assignees

@JorgSchwinger JorgSchwinger

Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
NorESM Development
Status: Done
Milestone
NorESM2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JorgSchwinger @TomasTorsvik