Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for configuration and namelist creation #303

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Minor fixes for configuration and namelist creation #303

merged 2 commits into from
Nov 9, 2023

Conversation

JorgSchwinger
Copy link
Contributor

No description provided.

Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍
Some CI-tests timed out. Will see if I can re-run, but shouldn't be essential.

@jmaerz jmaerz removed their request for review November 7, 2023 08:55
@jmaerz
Copy link
Collaborator

jmaerz commented Nov 8, 2023

Hi @JorgSchwinger , it shouldn't conflict with #305, but maybe it would be good to merge it nevertheless (I took myself out as a reviewer).

@TomasTorsvik TomasTorsvik added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Nov 9, 2023
@TomasTorsvik TomasTorsvik added this to the NorESM2.1 milestone Nov 9, 2023
@JorgSchwinger
Copy link
Contributor Author

I have put this on hold since it will interfere with the regression testing. There will be a fix needed since the C-isotope code cannot be switched on via user-namelist, but needs to go via env_run.xml.

@mvertens if you can tell me how to fix this, I could include it into this PR. Unless you think it is easier if you fix this after merging this PR?

@mvertens
Copy link
Contributor

mvertens commented Nov 9, 2023

@JorgSchwinger -

in blom/cime_config/testdefs/testmods_dirs/blom/hamocc1/
add a file shell_commands and in that file add the line
./xmlchange HAMOCC_CISO=TRUE
and in user_nl_blom remove the line
use_cisonew = .true.

You need to do this for every new xml variable that was introduced for the user_nl_blom variables that are in the user_nl_blom file

You should also do this for in blom/cime_config/testdefs/testmods_dirs/blom/hamocc2/

That should be it. Does that make sense?

@JorgSchwinger
Copy link
Contributor Author

Ok thank you for the instructions @mvertens, done.

I guess then this PR can be merged?

@mvertens
Copy link
Contributor

mvertens commented Nov 9, 2023

That would be fine with me.

@JorgSchwinger JorgSchwinger merged commit fcc2fce into NorESMhub:master Nov 9, 2023
12 checks passed
@JorgSchwinger JorgSchwinger deleted the fix-config_nml branch November 9, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants