-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes for configuration and namelist creation #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me 👍
Some CI-tests timed out. Will see if I can re-run, but shouldn't be essential.
Hi @JorgSchwinger , it shouldn't conflict with #305, but maybe it would be good to merge it nevertheless (I took myself out as a reviewer). |
I have put this on hold since it will interfere with the regression testing. There will be a fix needed since the C-isotope code cannot be switched on via user-namelist, but needs to go via env_run.xml. @mvertens if you can tell me how to fix this, I could include it into this PR. Unless you think it is easier if you fix this after merging this PR? |
in blom/cime_config/testdefs/testmods_dirs/blom/hamocc1/ You need to do this for every new xml variable that was introduced for the user_nl_blom variables that are in the user_nl_blom file You should also do this for in blom/cime_config/testdefs/testmods_dirs/blom/hamocc2/ That should be it. Does that make sense? |
Ok thank you for the instructions @mvertens, done. I guess then this PR can be merged? |
That would be fine with me. |
No description provided.