Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI test code section #333

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update CI test code section #333

merged 1 commit into from
Mar 14, 2024

Conversation

TomasTorsvik
Copy link
Contributor

  • Disable running test code with macos, throws a SIGFPE exception
  • Update "upload test log" to upload-artifact@v4, removes some deprecate warnings

@TomasTorsvik
Update CI test code section
8795aee 
- Disable running test code with macos, throws a SIGFPE exception
- Update "upload test log" to upload-artifact@v4, removes some deprecate warnings
@TomasTorsvik TomasTorsvik added the CI/meson Issues related to CI builds and/or meson label Mar 13, 2024
@TomasTorsvik TomasTorsvik self-assigned this Mar 13, 2024
jmaerz
jmaerz approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - Thanks!

JorgSchwinger
JorgSchwinger approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really competent to review this since I have no experience with CI, but it looks reasonable.

@TomasTorsvik TomasTorsvik merged commit ce9dfa0 into NorESMhub:master Mar 14, 2024
6 checks passed
@TomasTorsvik TomasTorsvik deleted the update_ci_test branch March 14, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorgSchwinger JorgSchwinger JorgSchwinger approved these changes

@jmaerz jmaerz jmaerz approved these changes

@matsbn matsbn Awaiting requested review from matsbn matsbn is a code owner

@milicak milicak Awaiting requested review from milicak

Assignees

@TomasTorsvik TomasTorsvik

Labels
CI/meson Issues related to CI builds and/or meson
Projects
NorESM Development
Status: Done
Milestone
NorESM2.3 - BLOM/iHAMOCC
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasTorsvik @JorgSchwinger @jmaerz