bugfix: openmp private declarations #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTorsvik
added
bug
|
I won't comment on the PR code. However, I was able to compile this PR together with #89 and the test began to run. The |
JorgSchwinger
approved these changes
May 10, 2021
matsbn
approved these changes
May 10, 2021
There was a problem hiding this comment.
Great you went through the iHAMOCC OpenMP directives! We should indeed have a standalone test case including iHAMOCC, but I do not have a setup for that currently. For now, maybe the correctness of hybrid MPI/OpenMP execution could be tested using the NorESM case @JorgSchwinger propose in PR #92? I'll approve anyway, since the changes in OpenMP directives should not break any existing functionality.
nordmoen
approved these changes
May 11, 2021
Declare indices of do loops (e.g. i,j,k) as private when using $OMP PARALLEL DO PRIVATE(...)
TomasTorsvik
force-pushed
the
bugfix_hamocc_openmp
branch
from
b841ec6 to
eb4c570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare indices of do loops (e.g. i,j,k) as private when using
$OMP PARALLEL DO PRIVATE(...)
This makes it possible to compile iHAMOCC with openMP. I have not run any test cases with this version yet, I guess this should be done either on Fram or Betzy. Is there a setup for running BLOM/iHAMOCC stand-alone (without using the NorESM framework)? I have been able to run BLOM stand-alone without the iHAMOCC part.