Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ESCOMP share1.1.5 #6

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

mvertens
Copy link

@mvertens mvertens commented Nov 24, 2024

Verified that this solves compilation problems when cdeps is updated to cdeps1.0.58.

@mvertens mvertens marked this pull request as draft November 24, 2024 14:38
@mvertens mvertens marked this pull request as ready for review November 26, 2024 09:56
@mvertens mvertens changed the title update to share1.1.5 update to ESCOMP share1.1.5 Nov 26, 2024
@mvertens mvertens added the enhancement New feature or request label Nov 26, 2024
@mvertens mvertens added this to the NorESM2.5 milestone Nov 26, 2024
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about an import

@@ -18,6 +18,7 @@ module nuopc_shr_methods
use ESMF , only : ESMF_Time, ESMF_TimeGet, ESMF_TimeSet, ESMF_ClockGetAlarm
use ESMF , only : ESMF_TimeInterval, ESMF_TimeIntervalSet, ESMF_TimeIntervalGet
use ESMF , only : ESMF_VM, ESMF_VMGet, ESMF_VMBroadcast, ESMF_VMGetCurrent
use ESMF , only : ESMF_ClockGetNextTime

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere? Can it be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I just removed it.

Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gold2718 gold2718 merged commit cdfbc3c into NorESMhub:noresm Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants