new aerocom namelist #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvertens
commented
Aug 28, 2024
mvertens
commented
- remove AEROCOM as a cpp variable - and introduce a new namelist to turn it on
- add a new file oslo_aero_diagnostics.F90 that activates oslo_aero (and aercom namelists) and is called from cam_diagnostics.F90. This makes it much easier to modularize where the oslo-aero diagnostics fields are defined.
- verified that running SMS_Ln9.ne30pg3_ne30pg3_mtn14.NF1850.derecho_intel.cam-outfrq9s with use_aerocom=.false. have bfb the same history files
- verified that running SMS_Ln9.ne30pg3_ne30pg3_mtn14.NF1850.derecho_intel.cam-outfrq9s with use_aerocom=.true. added the aerocom variables.
- a question about the new aerocom output appears in Diagnostic changes with AEROCOM noresm3_dev_simulations#33
- NOTE: this PR must also be accompanied my PRs to https://github.com/NorESMhub/CAM and to https://github.com/NorESMhub/CAM-Nor-physics
gold2718
force-pushed
the
feature/new_aerocom_namelist
branch
from
a35a70b
to
0db5173
Compare
Add OSLO Aero diagnostics to physpkg
gold2718
requested changes
Aug 28, 2024
src/oslo_aero_control.F90
Outdated
| ! Namelist variables: | ||
| real(r8) :: volc_fraction_coarse = 0.0_r8 !Fraction of volcanic aerosols in coarse mode | ||
| ! Public Namelist variables: | ||
| logical, public :: use_aerocom = .false. ! If true, turn on aerocom output |
src/oslo_aero_diagnostics.F90
Outdated
There was a problem hiding this comment.
The fields with unitless units should be updated to something descriptive (see #37).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.