Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release #88

Merged
merged 212 commits into from
Mar 10, 2022
Merged

First release #88

merged 212 commits into from
Mar 10, 2022

Conversation

ka7eh
Copy link
Member

@ka7eh ka7eh commented Mar 7, 2022

This will be tagged as 0.1.0. Nothing new to test. Just wanted to have an official PR that we can refer to later if needed.

huitang-earth and others added 30 commits March 31, 2021 18:49
- Bash install script using test conda env file
- CSV file with site names and coordinates
- Settings file centralising input information
  (only from workflow_setup_site_simulation.sh)
- Python script reading settings and executing 1st step of input
  preparation (mknoocnmap.pl)
- adapted to modified settings file structure
- separated from input preparation so that it can be imported by other modules
- draft surface data preparation module
- simplified install script
- run_example.sh script calling surface_data.py
Adapt settings parser and workaround for SAGA
…ts on saga (old version exceeds file limit).
InterfaceSettings class adapted for interactive changes
lasseke and others added 19 commits February 23, 2022 11:25
* add url

* replace img links to tinyimg, new map

* Update contributing.md

* Update index.md

* Update index.md

* Create code_of_conduct.md

* Update mkdocs.yml

* Update index.md

* Update mkdocs.yml

add code of conduct

* Create about_.md

mostly copied from the repo README

* new About page, rm sym.link

* Update index.md

* Update index.md

compsets

* Update index.md

atm forcing

* Update contributing.md

* Update land-sites.md

* Update land-sites.md

* Update mkdocs.yml

* Update contributing.md

* Delete code_of_conduct.md

* Create user_guide.md

* Update contributing.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update contributing.md

add docker readme link

* Update user_guide.md

* Update user_guide.md

* Update README.md

add links to logos

* Update about.md

add links to logos

* Update user_guide.md

* Update user_guide.md

* Update user_guide.md

* Update index.md

* Update user_guide.md

fix emojis

* Add files via upload

* Update user_guide.md

* Update user_guide.md

* Delete run_simulations.ipynb

* Add files via upload

* Update index.md

* Update docker.md

* Update index.md

* move compset header

* Update land-sites.md

* Update index.md

* Delete code_of_conduct.md

contents moved into contributing section

Co-authored-by: Lasse Keetz <57358428+lasseke@users.noreply.github.com>
Copy link
Collaborator

@evalieungh evalieungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me!

The run_simulations notebook I made has been made obsolete with the new Bokeh functionality, so we might choose to omit that file.

Under NREC_VM_setup, platform_dev branch is used in several scripts instead of main. I guess that's OK since NREC is mostly for development anyways, and if it's a problem we can fix it later.

@ka7eh
Copy link
Member Author

ka7eh commented Mar 8, 2022

Looks OK to me!

The run_simulations notebook I made has been made obsolete with the new Bokeh functionality, so we might choose to omit that file.

Under NREC_VM_setup, platform_dev branch is used in several scripts instead of main. I guess that's OK since NREC is mostly for development anyways, and if it's a problem we can fix it later.

Thanks. I replaced platform_dev with main in relevant parts of docs and scripts.
We can keep run_simulations for now for reference and remove it later.

@lasseke
Copy link
Collaborator

lasseke commented Mar 8, 2022

Great idea! We just need to be aware that some functionalities that appear to be included have not been implemented yet, e.g., some settings that are listed in the default settings file do not actually change the model configuration. Moreover, multiple functionalities and edge cases have not been tested thoroughly. I'm not entirely sure what the convention for releases is, but I would prefer if the release tag clarifies this in some way. For example, we could use something like v0.1.0-dev.

@ka7eh ka7eh merged commit 65f5139 into main Mar 10, 2022
@ka7eh ka7eh deleted the platform_dev branch June 9, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants