FILE-601 Receiver does not reports events #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matszczygiel
force-pushed
the
msz/FILE-601-receiver-does-not-reports-events
branch
from
8ca79b2
to
c53a4dc
Compare
… the sender side Signed-off-by: Mateusz Szczygieł <mateusz.szczygiel@nordsec.com>
…ion loop Signed-off-by: Mateusz Szczygieł <mateusz.szczygiel@nordsec.com>
Signed-off-by: Mateusz Szczygieł <mateusz.szczygiel@nordsec.com>
matszczygiel
force-pushed
the
msz/FILE-601-receiver-does-not-reports-events
branch
from
c53a4dc
to
d7deace
Compare
LukasPukenis
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the server's
HandlerLoopimplementations were firingFileEventTx::pause()in a spawned tokio task. I assume that spawning tokio task took a lot of time for a transfer with multiple big files and a new connection was started before it finished. Thus blocking events for the next transfer.