Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee word-aligned writes #366

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Guarantee word-aligned writes #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion iOSDFULibrary/Classes/Implementation/SecureDFU/Characteristics/SecureDFUPacket.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ internal class SecureDFUPacket: DFUCharacteristic {
self.logger = logger

if #available(iOS 9.0, macOS 10.12, *) {
packetSize = UInt32(characteristic.service.peripheral.maximumWriteValueLength(for: .withoutResponse))
// Make the packet size the first word-aligned value that's less than the maximum.
packetSize = UInt32(characteristic.service.peripheral.maximumWriteValueLength(for: .withoutResponse)) & 0xFFFFFFFC
if packetSize > 20 {
// MTU is 3 bytes larger than payload
// (1 octet for Op-Code and 2 octets for Att Handle).
Expand Down