Unwrapping optionals fixed #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places in the library optional variables that should never be nil were force-unwrapped. However, never say newer. It has been reported multiple times, e.g. in #394 , #213, #381. This PR fixes all force-unwrapped variables and makes sure they do not happen again. However, the behavior after the fixes is unknown. My assumption is, that the crashes were causes by sudden disconnection, which caused the DFU service being destroyed in the middle of uploading, so there should be no memory leaks, as everything gets cleaned up. But it may also happen, that the DFU process is in some weird state, that I cannot think of right now, that the service is disposed, but DFU executor is not, which would end up in handing cycling reference causing some objects not being disposed properly. But the chances of this are super low.