Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing error codes added #446

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Conversation

philips77
Copy link
Member

This PR fixes a crash when one of 3 missing status codes was received. The DFUError enum failed to be instantiated here:
https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/blob/d754328a4d13d28962f4db0f724ea2591be48478/iOSDFULibrary/Classes/Implementation/SecureDFU/Characteristics/ButtonlessDFU.swift#L313
This PR adds those cases to the enum.

@philips77 philips77 merged commit 63dbdbe into develop Jul 29, 2021
@philips77 philips77 deleted the bugfix/missing-error-codes branch July 29, 2021 21:56
@philips77 philips77 mentioned this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant