FEAT: add central manager options to DFUServiceInitiator #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@philips77 I opened this new mr. |
|
The commit was sent without an e-mail address, so GitHub can't match it to your account. Try doing what was explained here. |
|
Anyway, I can still merge it if you want. |
mateusforgi
force-pushed
the
fix/centralManagerOptions
branch
2 times, most recently
from
c95946e
to
a241fe9
Compare
Signed-off-by: Mateus Forgiarini da Silva <mateusforgi@gmail.com>
mateusforgi
force-pushed
the
fix/centralManagerOptions
branch
from
a241fe9
to
96c8c21
Compare
|
@philips77 you can merge it, signed the commits. |
|
@philips77 any update on that? |
philips77
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding central manager options to DFUServiceInitiator init. This is a breaking change since in swift a function is uniquely identified by its name and its parameters both arguments labels and types. Another option to avoid breaking changes would be to add another init.
#476