Modernised DFU Manifest #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philips77
requested changes
Jun 1, 2022
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/ManifestFirmwareInfo.swift
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Outdated
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Outdated
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Outdated
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Show resolved
Hide resolved
dinesharjani
force-pushed
the
manifest-code-cleanup
branch
2 times, most recently
from
2cef058
to
0a06545
Compare
|
Updated. |
philips77
requested changes
Jun 2, 2022
There was a problem hiding this comment.
I like the changes. One note, is that the metadata is optional and may contain invalid sizes. This is only for informational purpose for the user and the real sdSize and blSize are included in the dat file and signed.
One minor request to change is to rename SecureMetadata to something else, as the metadata is not at all secure and the name may be misleading. I would say Metadata and give there a comment.
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Outdated
Show resolved
Hide resolved
iOSDFULibrary/Classes/Utilities/DFUPackage/Manifest/SoftdeviceBootloaderInfo.swift
Outdated
Show resolved
Hide resolved
Instead of NSObject, so Objective-C classes, these are now structs. They're also Codable(s), so we don't need to do the JSON dance ourselves. I'm sure there are many more parts inside the library that deserve this same treatment, but we can't do it all at once. This is a small step.
dinesharjani
force-pushed
the
manifest-code-cleanup
branch
from
0a06545
to
80f7561
Compare
|
Fixed last two issues (renamed Metadata) |
philips77
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of NSObject, so Objective-C classes, these are now structs. They're also Codable(s), so we don't need to do the JSON dance ourselves. I'm sure there are many more parts inside the library that deserve this same treatment, but we can't do it all at once. This is a small step.