Logging improvements #487
Merged
Logging improvements #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaelleJoubert
added a commit
to GaelleJoubert/nordic_dfu
that referenced
this pull request
Sep 27, 2022
The DFULibrary dependency has been updated to V4.13.0, BUT, as mentionned in the iOSDFULibrary github changelog : https://github.com/NordicSemiconductor/IOS-DFU-Library/releases " Breaking: Creating DFUFirmware may now throw an error by @philips77 in NordicSemiconductor/IOS-DFU-Library#486 Logging improvements by @philips77 in NordicSemiconductor/IOS-DFU-Library#487 " So the code need to be change to a "do/try/catch", as the previous "gard/else" is now throwing errors at the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how classes and structs are being logged. Instead of a
descriptionproperty, now they extendCustomStringConvertiblewith the same property, which allows them to be converted to String automatically.