Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

Fix/sd rpc open crash issue #70

Merged
merged 7 commits into from
Jan 16, 2019
Merged

Conversation

kenr
Copy link
Contributor

@kenr kenr commented Jan 15, 2019

Invoking sd_rpc_open, sd_rpc_close and then sd_rpc_open made the driver crash

This PR contains:

  • a fix for the crash issue
  • improved logging from driver
  • improved status and log messages callbacks
  • tests for reproducing the bug
  • updated CMakeLists.txt to use new swig syntax

pc-ble-driver needs to be updated for this to work. See NordicSemiconductor/pc-ble-driver#188

rpc log and status was previously ignored, this commit adds
support for receiving log and status callback from the driver

The commit also add support for setting the driver log severity
level
This commit contains a class that parsers command line arguments
needed by driver. Class provides a method to remove those arguments
since unittest raise exception if unknown arguments are provided

The commit also contains a hack for the loading of pc-ble-driver binding
Deallocate result object from Python function callback
@kenr kenr merged commit a5efe72 into feature/s132v5_py3 Jan 16, 2019
@kenr kenr deleted the fix/sd_rpc_open_crash_issue branch January 16, 2019 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant