This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align number of advertise buffers with connectivity in SDK patch Fix issue with reuse of same advertise buffer Fix codec issue in relation to connected event
ble_gap_adv_set_configure() can be called while advertsing to provide new data for advertising. Serialization must handle that on both ends by freeing previously used buffers and allocating new one.
Update patch to latest from build server (33b7739)
Reference to instance was not specified lhs, making a copy of the buffers.
bihanssen
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chunfantasy
added a commit
that referenced
this pull request
Mar 5, 2019
…e-driver * 'master' of https://github.com/NordicSemiconductor/pc-ble-driver: (32 commits) Add status logging (#215) Feature/remove 115k2 baud rate support (#214) Fix/install dirs for tests examples (#213) Force armgcc toolchain version (#210) Adjust line in doc (#211) Remove test/example subdirectories, use what is provided by cmake (#212) Update documentation (#209) Remove baud wiggle (#204) Make creation of run test targets optional (#208) Check if status callback returns errors (#207) Update CMakeLists.txt (#203) Remove newline in log and status messages (#199) Fix/spurious errors advertising test (#197) Make terminate event happen earlier and stop adv/scan before closing (#196) Enable use of VCPKG_ROOT env variable (#195) Add hex as cmake module resource (#194) Fix/spurious error and compilation warning (#193) Add check of armgcc toolchain version (#192) Fix/advertise buffers (#191) Fix/support install prefix take 2 (#190) ...
mkarhumaa
pushed a commit
to mkarhumaa/pc-ble-driver
that referenced
this pull request
Oct 25, 2021
…r#191) * Update to nrf-ble-driver v4.1.4 * Linux: Update to use manylinux2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with changing advertising buffers during advertising