Bundle code in main/
#700
Merged
Bundle code in main/
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasem
reviewed
Aug 16, 2022
jonasem
reviewed
Aug 16, 2022
- dev → watch - webpack → build:dev - build → build:prod Because they all do run `webpack` and `esbuild` and the formerly called `webpack` and `dev` might both be used during development.
The ECMAScript module behavior is that all modules loading is hoisted before running different code. esbuild also adheres to this semantic. https://esbuild.github.io/content-types/#real-esm-imports Because of this we should extract all initialisation code into an module on its own.
datenreisender
force-pushed
the
feature/build_main
branch
from
688e550
to
29f4244
Compare
datenreisender
force-pushed
the
refactor/better_source_ipc_abstractions
branch
from
f60da36
to
a15d836
Compare
Base automatically changed from
refactor/better_source_ipc_abstractions
to
main
September 7, 2022 09:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this in place we can also start writing Typescript in
src/main.This does rename some of the scripts in
package.json, because they all do runwebpackandesbuildand the formerly calledwebpackanddevmight both be used during development:dev→watchwebpack→build:devbuild→build:prodBefore turning this from a draft into a real PR I still want to do: