NSM uplift to v1.4.0 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires Nordix/Meridio#231 |
LionelJouin
reviewed
Jun 8, 2022
controllers/attractor/lb-fe.go
Outdated
| @@ -104,7 +104,8 @@ func (l *LoadBalancer) getNscEnvVars(allEnv []corev1.EnvVar) []corev1.EnvVar { | |||
| e.Name == "NSM_NAME" || | |||
| e.Name == "NSM_DIAL_TIMEOUT" || | |||
| e.Name == "NSM_REQUEST_TIMEOUT" || | |||
| e.Name == "NSM_MAX_TOKEN_LIFETIME" { | |||
| e.Name == "NSM_MAX_TOKEN_LIFETIME" || | |||
| e.Name == "NSM_LIVENESSCHECKENABLED" { | |||
There was a problem hiding this comment.
maybe set it to false in go code line 98, so users won't be able to set the value in the template.
There was a problem hiding this comment.
I thought about it, but probably you are right, that currently changing this value could break the system, so it's better to hardcode it
LionelJouin
approved these changes
Jun 9, 2022
- new NSC env var NSM_LIVENESSCHECKENABLED=false to be used with Remote VLAN use case - env var NSM_IPV6_PREFIX removed from Remote VLAN NSE (NSM_CIDR_PREFIX covers both IPv4 and IPv6 CIDRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.