CAP_DAC_OVERRIDE no longer needed by non-root to interact with NSM #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
approved these changes
Aug 8, 2022
Since NSM v1.5 CAP_DAC_OVERRIDE capability is no longer required to interact with the nsm-sock mounted as hostPath volume. networkservicemesh/cmd-nsmgr#510 Affected images: proxy, load-balancer, TAPA, NSC (The official NSM cmd-nsc image can be used again. No need for a custom Dockerfile, unless e.g. ping is required to work.) Note: New images will NOT work on older NSM versions
Note: images must be in sync (binaries with excess file capabilities will NOT start if said capabilities are not provided to the container)
LionelJouin
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NSM v1.5 CAP_DAC_OVERRIDE capability is no longer required to
interact with the nsm-sock mounted as hostPath volume.
networkservicemesh/cmd-nsmgr#510
Affected images: proxy, load-balancer, TAPA, NSC
(The official NSM cmd-nsc image can be used again. No need for a custom
Dockerfile, unless e.g. ping is required to work.)
Description
Issue link
#263
Checklist
Will not work with NSM versions before v1.5.0 (if run as non-root)