Allow multi NAD in attractor

[LionelJouin]

Description

Multi NAD allows multiple network interfaces to be added to the attractor pods. The feature is already developed, only some conditions prevented its usage.
The interface name that will be injected in the frontend via the environment variable will be the one specified in the attractor specs

Example with multiple NADs: https://gist.github.com/LionelJouin/3cf494db1db592fb01b16ff16b6493c8

Issue link

/

Checklist

• Purpose
  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI
• Test
  • Unit test
  • E2E Test
  • Tested manually
• Introduce a breaking change
  • Yes (description required)
  • No

[zolug]

If I remember right, when the code appends the annotations, the interface name to be used in the POD is decided based on NAD config in the Attractor. Meaning, if there's no interface name in the NAD, the code will derive the name from the Specs.Interface.Name.
So, based on this change, the "primary" Attractor NAD supplying the external interface must not have an Interface Name set.
Also, in case multiple NADs are set, but none of them have an interface name specified, the code would try to re-use the same Specs.Interface.Name as POD interface names when appending the NADs to the resource template, wouldn't it?

[LionelJouin]

Yes, the user should give a specific interface name in the non-primary network-attachments in the attractor spec. The primary one should not have any name (or it should match with the .Specs.Interface.Name).

There is an example here: https://gist.github.com/LionelJouin/3cf494db1db592fb01b16ff16b6493c8
The attractor has 2 NADs, and the macvlan is a secondary one, the primary one is the vlan-100 that will get the ext-vlan0 name.