Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't merge #8

Closed
wants to merge 6 commits into from
Closed

Don't merge #8

wants to merge 6 commits into from

Conversation

lentzi90
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Co-authored-by: Matthew Booth <mbooth@redhat.com>
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch 5 times, most recently from 21a7a2f to f362e8c Compare January 24, 2024 14:29
@tormath1
Copy link

tormath1 commented Jan 24, 2024

@lentzi90 build is failing with:

Qemu stderr: Could not access KVM kernel module: Permission denied

IIRC, we need to patch the Docker image to use the root user - see this comment: kubernetes-sigs/image-builder#1092 (comment)

Note: For now it can only run builds without acceleration because it still uses the imagebuilder user but as imagebuilder needs to be in the KVM group and we don't know in advance the group ID of kvm group on the host: we would need to build and run the image with root user to allow KVM acceleration, this can be done in a follow-up PR.

Here's the patch: https://gist.github.com/tormath1/acbae5c6cd12420bb8ea137e25655c99

@lentzi90 lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch 6 times, most recently from 39d7ca8 to d813e41 Compare January 26, 2024 09:05
@lentzi90 lentzi90 closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants