Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add package directory to ListPackageRevision filtering
- make revision incrementation on rpkg approve work with --directory repos - add new Directory attribute to PackageRevisionKey - and use it when matching PackageRevisions to filter out from the List operation - package approval flow looks for previous copies of the package to determine new latest revision string (e.g. v1 -> v2) - this involves matching the package-for-approval's path attribute against existing packages' packageName attribute - however: - when a repo is registered using --directory to associate it with a subfolder in the upstream Git repo, packageName is deliberately trimmed of the directory attribute if it exists - but the path in the package-for-approval still has the directory part - so no existing packages can match to be counted as previous copies - therefore the revision can never increase beyond "v1" and the v1 tag is overwritten in Git with each new approval - this also results in previous package copies disappearing
- Loading branch information