Fix NullPointerException with unregistered response code #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checks registered response codes before marking * Adds a few additional default response codes * Misc. GoogleJavaFormat fixes
pdex
suggested changes
Jan 30, 2018
| @@ -89,7 +93,9 @@ private void executeHandler(ChannelHandlerContext ctx, int streamId, Route route | |||
| .handle(ctx.channel().attr(XrpcConstants.XRPC_REQUEST).get()); | |||
| } | |||
|
|
|||
| xctx.getMetersByStatusCode().get(h1Resp.status()).mark(); | |||
| Optional<Meter> responseMap = | |||
There was a problem hiding this comment.
Not really a map, or a response, maybe call it something like statusMeter?
andyday
reviewed
Jan 30, 2018
| @@ -89,7 +93,9 @@ private void executeHandler(ChannelHandlerContext ctx, int streamId, Route route | |||
| .handle(ctx.channel().attr(XrpcConstants.XRPC_REQUEST).get()); | |||
| } | |||
|
|
|||
| xctx.getMetersByStatusCode().get(h1Resp.status()).mark(); | |||
| Optional<Meter> responseMap = | |||
| Optional.ofNullable(xctx.getMetersByStatusCode().get(h1Resp.status())); | |||
There was a problem hiding this comment.
the getMetersByStatusCode() map should be wrapped to return an Optional. You shouldn't have to wrap it here...
* Rename `responseMap` to `statusMeter`
pdex
approved these changes
Jan 30, 2018
|
@spenserpothier this can be merged |
This was referenced Jan 30, 2018
spenserpothier
added a commit
that referenced
this pull request
Jan 30, 2018
* This commit somehow didn't get pushed to #92.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85