add sec/min/hrs/hr/days/wk/wks/weeks to time string parsing

[ketzacoatl]

it's a first pass, feedback/guidance on the details are welcome..

This aims to address #193.

[ketzacoatl]

Need to address the charLiteral bit..

[ketzacoatl]

@NorfairKing I'm not quite sure about this.. where is charLiteral coming from / what would you like to replace it with if switching to a string? I went to find my own replacement, but could not figure out which library you were getting charLiteral from.

[ketzacoatl]

@NorfairKing, I looked a little closer, and I believe smos-report is using charLiteral from megaparsec? https://www.stackage.org/haddock/lts-17.7/megaparsec-9.0.1/Text-Megaparsec-Char-Lexer.html#g:3

That doc section notes:

Note that you can use this parser as a building block to parse various string literals

And also:

Performance note: the parser is not particularly efficient at the moment.

So I wonder which function you would recommend smos-report use here in place of charLiteral. Should we use parsec's stringLiteral? https://www.stackage.org/haddock/lts-17.7/parsec-3.1.14.0/Text-Parsec-Token.html#v:stringLiteral

[NorfairKing]

@ketzacoatl charLiteral comes from megaparsec:

smos/smos-report/package.yaml

Line 26 in 83b5bd3

- megaparsec

: http://hackage.haskell.org/package/megaparsec-9.0.1/docs/Text-Megaparsec-Char-Lexer.html#v:charLiteral
I think we can use string instead: http://hackage.haskell.org/package/megaparsec-9.0.1/docs/Text-Megaparsec-Char.html#v:string

However, more importantly: This is a change in a parser. Parsers are notoriously hard to get right, so we'll want to start by writing tests. You can add them here:

smos/smos-report-gen/test/Smos/Report/TimeSpec.hs

Line 18 in 83b5bd3

spec :: Spec

[ketzacoatl]

Parsers are notoriously hard to get right, so we'll want to start by writing tests. You can add them here

I looked that over a few times, but am having a difficult time seeing it clearly, so I'm not even sure I can explain how that existing spec is testing timeP. Maybe we could meet up and review this together.

[NorfairKing]

Sure we can discuss it together!

[ketzacoatl]

@NorfairKing This is now ready for your review ;)

[NorfairKing]

LGTM