Fixes #25555: #5903
Merged
Fixes #25555: #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
fanf
reviewed
Sep 26, 2024
| // Show the first 4 chars: enough to disambiguate, and preserves 166 bits of randomness. | ||
| def exposeSecretBeginning: String = { | ||
| val acceptableToReveal = 4 | ||
| value.take(acceptableToReveal) + '*'.toString() * (value.size - acceptableToReveal) |
There was a problem hiding this comment.
You don't actually need to use the real length of * here, it might be already a valuable information. A fixed 6 * or whatever would be better.
There was a problem hiding this comment.
Yes, I wondered about it. As it is a Rudder token is should always be 32 chars long, and I wanted to avoid provided "false information" about the length that would hamper debugging. I'll try to find a suitable format.
There was a problem hiding this comment.
Updated with a bit different solution
|
PR updated with a new commit |
fanf
approved these changes
Sep 27, 2024
|
OK, squash merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/25555
The problem was that the log message used the raw token and not the typed
ApiToken(which has a customtoString). But it is useful to be able to identify an unknown token, and we can afford to lose a bit of randomness.