Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ServerData Protobuf to v2, switch internal struct to chrono + f32, update time sourcing logic #216

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Sep 28, 2024

Changes

See title. Was just going to just migrate serverdata and update time sourcing logic, but ran into a ton of bugs with ClientData using millisecond timestamps that would require refactoring every instantiation of the struct. So I said fug it and switched the struct to store a DateTime so any caller can pass in precise time. This DateTime is also how the prisma layer understands time. All times utc!!

Also switched the internal data representation to f32 from string because it was really annoying me all of the mapping and parsing back and forth we do. This can be reverted no biggie.

Test Cases

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

@jr1221 jr1221 self-assigned this Sep 28, 2024
@jr1221 jr1221 marked this pull request as ready for review September 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant