Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRC Debugs - Make form inputs consistent on finalize page #2316

Closed
Tracked by #1744
RChandler234 opened this issue Apr 4, 2024 · 0 comments · Fixed by #2426
Closed
Tracked by #1744

DRC Debugs - Make form inputs consistent on finalize page #2316

RChandler234 opened this issue Apr 4, 2024 · 0 comments · Fixed by #2426
Assignees
@vsp05
Labels
front-end medium

Comments

@RChandler234
Copy link
Contributor

RChandler234 commented Apr 4, 2024 •
edited
Loading

Right now only the name of a design review has this grey background, we want all the form inputs on the finalize design review page to also have this grey background to make the page look more consistent. It'd also be good to make the date and two time selectors be as rounded as the attendees and the name of the design review.
@RChandler234 RChandler234 mentioned this issue Apr 4, 2024
Open
78 tasks
vsp05 added a commit that referenced this issue May 17, 2024
@vsp05
#2316: made styling a little more consistent
609a916
vsp05 added a commit that referenced this issue May 17, 2024
@vsp05
Merge branch 'develop' of https://github.com/Northeastern-Electric-Ra…
0f4bfe4 
…cing/FinishLine into #2316-consistent-form-inputs
@vsp05 vsp05 mentioned this issue May 17, 2024
Closed
Peyton-McKee added a commit that referenced this issue May 18, 2024
@Peyton-McKee
Merge branch 'feature/multitenancy' into #2316-consistent-form-inputs
cbeecd3
vsp05 added a commit that referenced this issue May 19, 2024
@vsp05
#2316: switched to new branch due to git issues - cleaned up code by …
c83b6b9 
…passing in params to objects, and fixed the border problem by making the border slightly bigger
@vsp05 vsp05 mentioned this issue May 19, 2024
Merged
@Peyton-McKee Peyton-McKee moved this from Todo to Under Review in FinishLine Project Board May 19, 2024
vsp05 added a commit that referenced this issue May 20, 2024
@vsp05
#2316: removed div and changed styling objects
ff13a9e
vsp05 added a commit that referenced this issue May 20, 2024
@vsp05
#2316: removed unused imports
0eaaf82
vsp05 added a commit that referenced this issue May 21, 2024
@vsp05
#2316: added comments to describe the styling consts
f3f2084
vsp05 added a commit that referenced this issue May 21, 2024
@vsp05
#2316: changed styling object names
70f1824
Peyton-McKee added a commit that referenced this issue May 21, 2024
@Peyton-McKee
Merge pull request #2426 from Northeastern-Electric-Racing/#2316-part-2
74f33c4 
#2316: Standardize Date View
@github-project-automation github-project-automation bot moved this from Under Review to Done in FinishLine Project Board May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsp05 vsp05

Labels
front-end medium
Projects
FinishLine Project Board
Archived in project
Milestone
No milestone
2 participants
@RChandler234 @vsp05