Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteWorkPackageView should use an NERFormModal #2496

Closed
3 tasks done
RChandler234 opened this issue May 23, 2024 · 0 comments · Fixed by #2629
Closed
3 tasks done

DeleteWorkPackageView should use an NERFormModal #2496

RChandler234 opened this issue May 23, 2024 · 0 comments · Fixed by #2629
Assignees
@vsp05
Labels
front-end medium

Comments

@RChandler234
Copy link
Contributor

RChandler234 commented May 23, 2024 •
edited by superhvarn
Loading

Description

Right now a lot of places use the default Dialog component for a modal instead of the styled NERModal that we've created. This ticket is to replace the use of the MUI dialog with the NERFormModal component in the DeleteWorkPackageView component.

Acceptance Criteria

  • All use of the dialog component is removed from DeleteWorkPackageView
  • The NERFormModal Component is used instead
  • All functionality is unaffected

Proposed Solution

See how we've used the NERFormModal elsewhere for examples
@Peyton-McKee Peyton-McKee moved this from Todo to In Progress in FinishLine Project Board May 24, 2024
vsp05 added a commit that referenced this issue May 30, 2024
@vsp05
#2496 changed Dialog component to NERFormModal with delete as the sub…
a1e8fbd 
…mitText
@vsp05 vsp05 mentioned this issue May 30, 2024
Merged
vsp05 added a commit that referenced this issue May 31, 2024
@vsp05
#2496 removed unnecessary name field
3cd96cc
vsp05 added a commit that referenced this issue May 31, 2024
@vsp05
Merge branch 'develop' into #2496-change-DeleteWorkPackageView-to-NER…
0e5022b 
…FormModal
vsp05 added a commit that referenced this issue May 31, 2024
@vsp05
Merge branch 'develop' into #2496-change-DeleteWorkPackageView-to-NER…
6c70d37 
…FormModal
vsp05 added a commit that referenced this issue Jun 9, 2024
@vsp05
#2496: change yup schema and hide delete button until wbsnum is correct
701e09e
vsp05 added a commit that referenced this issue Jun 9, 2024
@vsp05
#2496: fixed delete button so that it is gray from the start (using i…
fe9ec85 
…sValid)
walker-sean added a commit that referenced this issue Jun 12, 2024
@walker-sean
Merge pull request #2629 from Northeastern-Electric-Racing/#2496-chan…
f5ae7cf 
…ge-DeleteWorkPackageView-to-NERFormModal

#2496 change delete work package view to ner form modal
@github-project-automation github-project-automation bot moved this from In Progress to Done in FinishLine Project Board Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsp05 vsp05

Labels
front-end medium
Projects
FinishLine Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2496 change delete work package view to ner form modal Northeastern-Electric-Racing/FinishLine
2 participants
@RChandler234 @vsp05