Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - Denied request amounts are still included in the "currently owed" total #2674

Closed
superhvarn opened this issue Jun 19, 2024 · 0 comments · Fixed by #2677
Closed

[Bug] - Denied request amounts are still included in the "currently owed" total #2674

superhvarn opened this issue Jun 19, 2024 · 0 comments · Fixed by #2677
Assignees
@AShyamkumar19
Labels
bug Something isn't working front-end straightforward

Comments

@superhvarn
Copy link
Contributor

superhvarn commented Jun 19, 2024 •
edited
Loading

Description

Reimbursemnt requests that are denied still have amounts showing in "currently owed"

Acceptance Criteria

Currently owed only has the amounts for valid reimbursement requests.

Proposed Solution

Filter out reimbursement requests to not include statuses with "DENIED".
@superhvarn superhvarn added bug Something isn't working straightforward front-end labels Jun 19, 2024
@AShyamkumar19 AShyamkumar19 self-assigned this Jun 20, 2024
AShyamkumar19 added a commit that referenced this issue Jun 24, 2024
@AShyamkumar19
#2674 Fixed reimbursement request bug
879aaf1
@AShyamkumar19 AShyamkumar19 linked a pull request Jun 24, 2024 that will close this issue
#2674 Fixed reimbursement request bug #2677
Merged
11 tasks
AShyamkumar19 added a commit that referenced this issue Jun 25, 2024
@AShyamkumar19
#2674 Prettier check
1b125b4
@AShyamkumar19 AShyamkumar19 mentioned this issue Jun 25, 2024
Merged
11 tasks
AShyamkumar19 added a commit that referenced this issue Jun 29, 2024
@AShyamkumar19
#2674 Checks if any statuses are denied
2546c2c
AShyamkumar19 added a commit that referenced this issue Jun 29, 2024
@AShyamkumar19
#2674 Prettier Check
422ce32
walker-sean added a commit that referenced this issue Jun 30, 2024
@walker-sean
Merge pull request #2677 from Northeastern-Electric-Racing/2674-bug-d…
a98e0ef 
…enied-request-amounts-are-still-included-in-the-currently-owed-total-1

#2674 Fixed reimbursement request bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AShyamkumar19 AShyamkumar19

Labels
bug Something isn't working front-end straightforward
Projects
None yet
Milestone
No milestone
2 participants
@superhvarn @AShyamkumar19