Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2149-work-package-template-endpoint #2361

Merged
merged 25 commits into from
May 21, 2024
Merged

#2149-work-package-template-endpoint #2361

merged 25 commits into from
May 21, 2024

Conversation

lphan48
Copy link
Contributor

@lphan48 lphan48 commented Apr 22, 2024 •
edited by bderbs30
Loading

Changes

  • created an endpoint to create a new work package template

Test Cases

image

image

image

image

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2149

@lphan48 lphan48 requested a review from bderbs30 April 22, 2024 17:14
@lphan48 lphan48 self-assigned this Apr 22, 2024
@bderbs30 bderbs30 self-assigned this May 10, 2024
@Peyton-McKee Peyton-McKee changed the base branch from develop to feature/multitenancy May 18, 2024 15:38
@bderbs30 bderbs30 requested review from Peyton-McKee and removed request for bderbs30 May 18, 2024 23:01
Peyton-McKee
Peyton-McKee requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this really shouldnt work with a blockedBy supplied.

src/backend/src/routes/work-package-templates.routes.ts Outdated Show resolved Hide resolved
src/backend/src/routes/work-package-templates.routes.ts Outdated Show resolved Hide resolved
Peyton-McKee
Peyton-McKee requested changes May 19, 2024
View reviewed changes
src/backend/src/utils/utils.ts Outdated Show resolved Hide resolved
src/backend/src/utils/utils.ts Outdated Show resolved Hide resolved
Peyton-McKee
Peyton-McKee approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@Peyton-McKee Peyton-McKee merged commit 338ee07 into feature/multitenancy May 21, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #2149-work-package-endpoint branch May 21, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peyton-McKee Peyton-McKee Peyton-McKee approved these changes

Assignees

@lphan48 lphan48

@bderbs30 bderbs30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work Package Templates - Create Endpoint
3 participants
@lphan48 @Peyton-McKee @bderbs30