#2313 implemented route, controller, and services #2391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
requested changes
May 16, 2024
|
|
||
| // verify user is allowed to set the status of the design review | ||
| if (!isAdmin(user.role) && user.userId !== originaldesignReview.userCreatedId) { | ||
| throw new AccessDeniedMemberException('set the status of a design review'); |
There was a problem hiding this comment.
accessdeniedadminonly acception
There was a problem hiding this comment.
or http exception saying only admins or the creator can do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created a endpoint for setting the status of a design review. It can be used by the creator of the design review or app admins. Implemented behavior in design-review, routes, controllers, and services files.
Test Cases
tested with postman, results shown below
Screenshots
before change - with app admin:
after change - with app admin:
set status works when creator is not admin
invalid when user is not admin or creator
invalid status - produces error
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2313