-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitenant Application #2397
Merged
Peyton-McKee
merged 19 commits into
Northeastern-Electric-Racing:feature/multitenancy
from
Peyton-McKee:develop
May 18, 2024
Merged
Multitenant Application #2397
Peyton-McKee
merged 19 commits into
Northeastern-Electric-Racing:feature/multitenancy
from
Peyton-McKee:develop
May 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0833fb
into
Northeastern-Electric-Racing:feature/multitenancy
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Code for a multitenant application
Notes
Will have to delete mocked tests and rewrite them to be unmocked
Will have to consider how we want users to join organizations
Will have to consider how we want to display / fill out description bullets because it definitely will not work as it is - done
I wanna write full system tests for the application
Need to verify all parts of application are still working
Will have to talk about data migration if we even wanna do it
Probably going to wait until gantt chart is fixed before merging
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lock
changes (unless dependencies have changed)Closes # (issue #)