#2392 auto cr post release #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RChandler234
requested changes
May 18, 2024
src/backend/src/prisma/migrations/20240515230546_add_original_data_to_scope_cr/migration.sql
Outdated
Show resolved
Hide resolved
src/frontend/src/pages/ChangeRequestDetailPage/DiffSection/DiffSection.tsx
Outdated
Show resolved
Hide resolved
| summary: associatedProject!.summary, | ||
| rules: associatedProject!.rules, | ||
| goals: { | ||
| connect: associatedProject!.goals.map((goal) => ({ descriptionId: goal.descriptionId })) |
There was a problem hiding this comment.
- I wouldn't do the not null (!) if u can, it's generally not great bc it can let errors slip through, 2. I think this line needs to be updated to be projectQueryArgs, because goals for the original project is showing up as undefined when I try to review a Create Project CR and it's causing an error
src/frontend/src/pages/ProjectDetailPage/ProjectForm/LinksEditView.tsx
Outdated
Show resolved
Hide resolved
RChandler234
requested changes
May 25, 2024
| @@ -66,7 +66,7 @@ export const descriptionBulletToChangeListValue = ( | |||
| ): ChangeListValue<DescriptionBulletPreview> => { | |||
| return { | |||
| element: descriptionBullet, | |||
| comparator: `${descriptionBullet.id}`, | |||
| comparator: `${descriptionBullet.detail}`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See ticket for list of changes
Notes
Reviewing a project now does not work due to the schema change. I have poured myself over the error message trying to see where the description bullets are lost. Reviewing a work package works though, and the diff actually looks right!
Also, dates are being really funky, probably the time zone thing again:
These dates should be unchanged:
Also, neither date is a Monday; I think they just move back each cr
Screenshots
If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window
If you did any manual testing (e.g., with Postman), put screenshots of the http request and before and after of the db
If none of this applies, you can delete this section
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2392