Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2432: deleted if statement that caused duplicate tab #2497

Merged
merged 1 commit into from
May 24, 2024
Merged

#2432: deleted if statement that caused duplicate tab #2497

merged 1 commit into from
May 24, 2024

Conversation

wavehassman
Copy link
Contributor

@wavehassman wavehassman commented May 23, 2024 •
edited
Loading

Changes

deleted an if statement that double checked if the user isFinance therefore adding another tab
"canViewAllReimbursementRequests" already checks if the user is finance or an admin

Screenshots

Screenshot 2024-05-23 at 1 28 36 PM ^^ as Milburn Pennybags

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2432

@wavehassman wavehassman self-assigned this May 23, 2024
@wavehassman wavehassman requested a review from Zwendle May 23, 2024 17:36
Zwendle
Zwendle approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Zwendle Zwendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work💯

@Peyton-McKee Peyton-McKee merged commit 39203cf into develop May 24, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #2432-delete-duplicate-all-club-refunds-tab branch May 24, 2024 19:02
@Peyton-McKee Peyton-McKee mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peyton-McKee Peyton-McKee Peyton-McKee approved these changes

@Zwendle Zwendle Zwendle approved these changes

Assignees

@wavehassman wavehassman

Labels
Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wavehassman @Zwendle @Peyton-McKee