Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2325 drc debugs infer team type from work package #2602

Merged

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented May 25, 2024

Changes

  • autofills team type from work package
  • added teams to work package shared type
  • updated work package transformer with teams
  • updated project transformer with teams for the work package property it has
  • updated query args for work package to include team type

Screenshots

Screenshot 2024-05-25 at 4 38 41 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2325 )

@superhvarn superhvarn requested a review from Peyton-McKee May 25, 2024 20:39
@superhvarn superhvarn requested a review from Peyton-McKee May 27, 2024 21:13
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just delete that one line

src/backend/src/transformers/projects.transformer.ts Outdated Show resolved Hide resolved
@superhvarn superhvarn requested a review from Peyton-McKee May 28, 2024 22:34
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yippeeee

@Peyton-McKee Peyton-McKee merged commit 8bbccc6 into develop May 29, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the 2325-drc-debugs-infer-team-type-from-work-package branch May 29, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants