Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2618-CaioDaSilva-FixAssemblyError #2619

Merged
merged 1 commit into from
May 28, 2024
Merged

#2618-CaioDaSilva-FixAssemblyError #2619

merged 1 commit into from
May 28, 2024

Conversation

caiodasilva2005
Copy link
Contributor

Changes

Fixed Error when making a new assembly

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2618

@caiodasilva2005 caiodasilva2005 self-assigned this May 28, 2024
@caiodasilva2005 caiodasilva2005 changed the title #2618-making assembly is working #2618-CaioDaSilva-FixAssemblyError May 28, 2024
Peyton-McKee
Peyton-McKee approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant manually review until after work but this would definitely cause an error

@Peyton-McKee Peyton-McKee merged commit 3604d55 into develop May 28, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #2618-CaioDaSilva-FixAssemblyError branch May 28, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peyton-McKee Peyton-McKee Peyton-McKee approved these changes

@RChandler234 RChandler234 Awaiting requested review from RChandler234

Assignees

@caiodasilva2005 caiodasilva2005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BOM - Creating An Assembly On Project Throws Error
2 participants
@caiodasilva2005 @Peyton-McKee