Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2628 Delete Work Package Template Button #2645

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

walker-sean
Copy link
Member

Changes

Added delete buttons for work package templates and a modal to confirm that connects to the hook

Notes

I also fixed some typos I found

Screenshots

If you made UI changes you must post a screenshot of the whole page for each change in 1) a normal sized window and 2) the smallest possible window

If you did any manual testing (e.g., with Postman), put screenshots of the http request and before and after of the db

If none of this applies, you can delete this section

image

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2628

Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shwag

Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good we probably shouldnt merge it until aaryans is good if u wanna check that out first. Also i think he mightve made the hooks in that one too

@Aaryan1203
Copy link
Contributor

Aaryan1203 commented Jun 4, 2024

This looks good we probably shouldnt merge it until aaryans is good if u wanna check that out first. Also i think he mightve made the hooks in that one too

Wait which of my tickets? Did you mean Harishs forms that he's doing? My hooks are already merged in btw. @Peyton-McKee

@Peyton-McKee
Copy link
Contributor

oh nevermind then I missed that

@Peyton-McKee Peyton-McKee merged commit aba31de into develop Jun 4, 2024
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #2628-delete-template-button branch June 4, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Work Package Template] - Add delete work package template button
3 participants