Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2157 work package templates createedit form #2646

Merged
merged 32 commits into from
Jul 2, 2024
Merged

#2157 work package templates createedit form #2646

merged 32 commits into from
Jul 2, 2024

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Jun 4, 2024 •
edited
Loading

Changes

  • Clicking on a work package template will take user to edit form
  • Clicking create new work package template will also take the user to the form
  • Work Package Template Details and Work Package Details
  • Blocked By is autofilled in the edit form

Screenshots

Screenshot 2024-06-09 at 12 54 55 PM Screenshot 2024-06-09 at 12 55 04 PM Screenshot 2024-06-09 at 12 55 17 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2157 )

@superhvarn superhvarn linked an issue Jun 4, 2024 that may be closed by this pull request
Work Package Templates - Create/Edit Form #2157
Closed
3 tasks
@superhvarn superhvarn self-assigned this Jun 4, 2024
Aaryan1203
Aaryan1203 requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't delete a work opackage template anymore. I think the link takes up the entire component.

The cancel button doesn't work on the edit page

Aaryan1203
Aaryan1203 requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good just a couple comments

src/frontend/src/pages/AdminToolsPage/AdminToolsProjectsConfig.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/ProjectsConfig/WorkPackageTemplateTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateForm.tsx Outdated Show resolved Hide resolved
@superhvarn superhvarn requested a review from Aaryan1203 June 13, 2024 01:09
Aaryan1203
Aaryan1203 previously approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@walker-sean walker-sean changed the title Refs/heads/2157 work package templates createedit form #2157 work package templates createedit form Jun 16, 2024
walker-sean
walker-sean requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really love the form, and it works really well!

src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateFormView.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/AdminToolsPage/ProjectsConfig/WorkPackageTemplateTable.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/CreateWorkPackageTemplate.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/CreateWorkPackageTemplate.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateForm.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateForm.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/EditWorkPackageTemplate.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/EditWorkPackageTemplate.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateFormView.tsx Outdated Show resolved Hide resolved
@superhvarn superhvarn requested a review from walker-sean June 17, 2024 19:53
walker-sean
walker-sean requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/frontend/src/pages/WorkPackageTemplateForm/EditWorkPackageTemplate.tsx Outdated

const { data: workPackageTemplate } = useSingleWorkPackageTemplate(workPackageTemplateId!);

const defaultValues = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import the type for this (which can be renamed WorkPackageTemplateFormInputs or something to declare the type here

You can actually use the spread operator for all of the fields, and will just manually need to override stage and blocked by

src/frontend/src/pages/WorkPackageTemplateForm/WorkPackageTemplateForm.tsx Outdated Show resolved Hide resolved
@superhvarn superhvarn requested a review from walker-sean June 23, 2024 20:20
@superhvarn superhvarn requested a review from walker-sean June 29, 2024 12:48
walker-sean
walker-sean approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walker-sean walker-sean merged commit 3e18f8e into develop Jul 2, 2024
4 checks passed
@walker-sean walker-sean deleted the 2157-work-package-templates---createedit-form branch July 2, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walker-sean walker-sean walker-sean approved these changes

@Aaryan1203 Aaryan1203 Aaryan1203 left review comments

Assignees

@superhvarn superhvarn

Labels
difficult front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work Package Templates - Create/Edit Form
3 participants
@superhvarn @Aaryan1203 @walker-sean