Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2714 FAQs dropdown component #2856

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

dreifusjack
Copy link
Contributor

@dreifusjack dreifusjack commented Sep 27, 2024

Changes

Created a dropdown component. Mapped all FAQs with the new dropdown component to the recruitment page.

Notes

I could not get the arrow icon to rotate 90º as it does in the example picture I can do some extra styling with the expandIcon but I didn't know if it was a big deal. Let me know if you want that to be changed.

Screenshots

Screenshot 2024-09-27 at 5 01 58 PM Screenshot 2024-09-27 at 5 02 29 PM Screenshot 2024-09-27 at 5 04 43 PM

To Do

  • Any requested styling changes

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2714

@Aaryan1203 Aaryan1203 changed the base branch from develop to feature/recruitment_and_onboarding September 27, 2024 21:32
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, great job! I think one of the components you can use for the arrows is like chevron right or chevron down. Try one of those it could help.

Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Aaryan1203 Aaryan1203 merged commit 5000bc4 into feature/recruitment_and_onboarding Oct 1, 2024
4 checks passed
@Aaryan1203 Aaryan1203 deleted the #2714-FAQs-Component branch October 1, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Create FAQs Component
2 participants