-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2811 setup onboarding progress bar #3084
#2811 setup onboarding progress bar #3084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the progress bar look a little more like the mocks and also for the checklists, i think the progress bar should be next to the text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge if these comments dont uncover anything
<Grid item xs={12} md={5} sx={{ display: 'flex', justifyContent: 'flex-end' }}> | ||
<Typography sx={{ fontSize: '2em' }}>Finished</Typography> | ||
</Grid> | ||
<NERButton variant="contained">Finished?</NERButton> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this button doesnt do anything?
3c4e573
into
feature/recruitment_and_onboarding
Changes
Screenshots
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lock
changes (unless dependencies have changed)Closes # (issue #2811)