Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2811 setup onboarding progress bar #3084

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Dec 20, 2024

Changes

  • progress bar for checklists
  • overall progress
  • finish button

Screenshots

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2811)

@superhvarn superhvarn self-assigned this Dec 20, 2024
@superhvarn superhvarn changed the base branch from develop to feature/recruitment_and_onboarding December 20, 2024 00:09
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the progress bar look a little more like the mocks and also for the checklists, i think the progress bar should be next to the text

@Aaryan1203 Aaryan1203 self-assigned this Dec 20, 2024
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge if these comments dont uncover anything

<Grid item xs={12} md={5} sx={{ display: 'flex', justifyContent: 'flex-end' }}>
<Typography sx={{ fontSize: '2em' }}>Finished</Typography>
</Grid>
<NERButton variant="contained">Finished?</NERButton>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this button doesnt do anything?

src/frontend/src/pages/HomePage/components/Checklist.tsx Outdated Show resolved Hide resolved
@Aaryan1203 Aaryan1203 merged commit 3c4e573 into feature/recruitment_and_onboarding Dec 21, 2024
4 checks passed
@Aaryan1203 Aaryan1203 deleted the #2811-setup-onboarding-progress-bar branch December 21, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants