Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2816 confirm onboarding checklist modal #3090

Open
wants to merge 3 commits into
base: feature/recruitment_and_onboarding
Choose a base branch
from
Open

#2816 confirm onboarding checklist modal #3090

wants to merge 3 commits into from

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Dec 21, 2024 •
edited
Loading

Changes

  • modal complete
  • user is promoted when user confirms

Screenshots

Screenshot 2024-12-20 at 7 40 20 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2816 )

@superhvarn superhvarn changed the base branch from develop to feature/recruitment_and_onboarding December 21, 2024 00:42
@superhvarn superhvarn self-assigned this Dec 21, 2024
Aaryan1203
Aaryan1203 requested changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it so when you click the finished button on the onboarding home page then this shows up. Also can the modal be more rounded like the other ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaryan1203 Aaryan1203 Aaryan1203 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@superhvarn superhvarn

Labels
front-end straightforward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superhvarn @Aaryan1203