Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#284 added cancelled enum #265

Merged
merged 1 commit into from
Sep 25, 2024
Merged

#284 added cancelled enum #265

merged 1 commit into from
Sep 25, 2024

Conversation

A-narang
Copy link
Contributor

modified methods to add cancelled enum + added tests

Pull Request

Brief Summary

  • Added cancelled enum + modified toArticleStatus method to add a case for cancelled

Questions / Considerations for the Future

-

API Changes

-

Database Changes

-

New Tests

  • Added tests for Cancelled enum (toString, toArticleStatus, list, listr)

Closes #248

@A-narang
added cancelled enum
3849264 
modified methods to add cancelled enum + added tests
@A-narang A-narang requested review from a team as code owners September 21, 2024 19:29
@A-narang A-narang changed the title added cancelled enum #284 added cancelled enum Sep 21, 2024
ethanszeto
ethanszeto approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@ethanszeto ethanszeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

suttonspindler
suttonspindler approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@suttonspindler suttonspindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ethanszeto ethanszeto merged commit 3193a96 into main Sep 25, 2024
1 check passed
@ethanszeto ethanszeto deleted the #248-Create-a-Cancelled-Enum-for-ArticleStatus branch September 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suttonspindler suttonspindler suttonspindler approved these changes

@ethanszeto ethanszeto ethanszeto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Cancelled Enum for ArticleStatus
3 participants
@A-narang @ethanszeto @suttonspindler