Added new StringJoin() utility function #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function joins a sequence of strings with an optional separator in between the elements. Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
There was an error running your pipeline, see logs for details. |
craigcomstock
approved these changes
Dec 8, 2023
vpodzime
approved these changes
Dec 8, 2023
|
|
||
| Writer *const writer = StringWriter(); | ||
| const size_t len = SeqLength(seq); | ||
| for (size_t i = 0; i < len; i++) |
There was a problem hiding this comment.
I'd do i < (len -1) writing the separator after every item and then writing the last item after the for loop without a separator. But YMMV.
There was a problem hiding this comment.
Then the program would crash if the sequence was empty, right ? 🤔
There was a problem hiding this comment.
Yup, but that's easy to check upfront. Which is better than having an unnecessary if inside the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function joins a sequence of strings with an optional separator in between the elements.